Assertion JiT integration - #2223
Open
rafal-hawrylak wants to merge 3 commits into
Open
Conversation
rafal-hawrylak
requested review from
krushangSk17
and removed request for
a team
July 15, 2026 14:11
Collaborator
|
Is this PR rebased onto any other PRs? If yes - please send to review after those are merged. |
rafal-hawrylak
force-pushed
the
assertion-jit-integration
branch
3 times, most recently
from
July 16, 2026 07:34
5efa010 to
2708c15
Compare
rafal-hawrylak
force-pushed
the
assertion-jit-integration
branch
from
July 22, 2026 20:08
2708c15 to
88a88c7
Compare
Runs 4 JiT actions and asserts the CANCEL_EVENT listener count returns to zero after the run completes. Fails today (leaks 4 listeners) — will pass once run.ts unregisters each per-compile cancel handler.
Runner.compileJitAction was missing an assertion branch in the target-type selector, so assertions fell through to JIT_COMPILATION_TARGET_TYPE_UNSPECIFIED and the compiler rejected them. createTasksFromJitResponse also had no branch for jitResponse.assertion, so the compiled query never reached executionSql.createAssertionTasks. Wire both: select ASSERTION for assertion actions, and hydrate a dataform.Assertion from the JiT response before building tasks. Tests: - Runner-level unit test (jit_run_test.ts) drives a single JiT assertion action end-to-end and checks the resulting task set. - CLI e2e test (index_jit_runtime_test.ts) uses assert().jitCode() against dry-run BigQuery.
rafal-hawrylak
force-pushed
the
assertion-jit-integration
branch
from
August 5, 2026 17:59
88a88c7 to
160c6a7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assertion actions were not integrated into the JiT compilation runtime, even though the compiler (core/jit_compiler.ts) already supports them. Two gaps in Runner:
This PR wires both - assertions with jitCode now compile through the JiT worker and produce the same task set as their AoT counterparts (via executionSql.createAssertionTasks).